Log an error, when GC with Image in unsupported use cases

[akoch-yatta]

We should log an error or at least a warning when creating a GC on any image that is not supposed to be used for modifying it. This includes at least:

• all dynamic images (retrieved via any of the existing providers) except ImageGcDrawer
• all images for which handles in other zoom values have already been created

[ShahzaibIbrahim]

For the case where we use initialize Image with GC with providers we see spam of logs due to scaleToUsingSmoothScaling method used in ImageFileNameProvider and ImageDataProviders. For now we hold it, until we find a way to scale image smoothly in providers without using GC.

[ShahzaibIbrahim]

Currently blocked, see eclipse-platform/eclipse.platform.swt#1979 (review)

[HeikoKlare]

What is the prerequisite for unblocking this issue?

[ShahzaibIbrahim]

@HeikoKlare There are two things actually.

1. We cant log an error in case when GC is used for Images created with ImageProvider because we do it in Smooth scaling all the time and that floods the logs.
2. There was a debate between you and christoph whether to throw an error or just log a warning and from the conversation I am not sure if we have a conclusion yet.

If I know the answer of these two, this ticket will be unblocked.

[HeikoKlare]

The problem is: I don't see that we have any trigger for the two mentioned issues being resolved or at least worked on, so this will probably remain blocked forever. Let's put this on the weekly topic list for short discussion and finding an agreement how to proceed.

[HeikoKlare]

Todo:

• Guard the warning behind SWT strict checks
• Solve the issue with reporting unsupported use case in smooth scaling