Skip to content

Extract image data provider details into internal subclasses #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akoch-yatta opened this issue Dec 2, 2024 · 4 comments · Fixed by eclipse-platform/eclipse.platform.swt#1667
Assignees
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@akoch-yatta
Copy link

akoch-yatta commented Dec 2, 2024

Extract image creation strategy details into internal suclasses, e.g. ImageDataProvider, ImageFilenameProvider, etc.

@akoch-yatta akoch-yatta added this to HiDPI Dec 2, 2024
@akoch-yatta akoch-yatta converted this from a draft issue Dec 2, 2024
@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature labels Dec 2, 2024
@akoch-yatta akoch-yatta added this to the 4.35 M1 milestone Dec 2, 2024
@akoch-yatta
Copy link
Author

Follow up of #122

@amartya4256 amartya4256 moved this from 🔖 Ready: Atomic to 👀 In Review in HiDPI Dec 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in HiDPI Dec 19, 2024
@HeikoKlare
Copy link
Contributor

Correct me if I am wrong, @akoch-yatta, but wasn't the goal of the Image refactoring to get rid of image-type-specific metadata, in particular the initialNativeZoom that is not relevant for images based on data or file name providers? So that a concrete image then either has an initial zoom with the according image data that need to be scaled upon requesting data at a different zoom or has some data provider that is capable of providing the correct data without any data at some initial zoom.

@akoch-yatta
Copy link
Author

Yes, problem is extracting the "base case" is much more complicated as expected because some of those attributes are used in other parts of SWT directly. Therefor we decided to start with extracting only the "new" cases. But I think we were missing a followup ticket, so I added #171

@HeikoKlare
Copy link
Contributor

Great, thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants