From 4e5a72868a6c067f137100a5931ea0bb7ea5bed7 Mon Sep 17 00:00:00 2001 From: smolck <46855713+smolck@users.noreply.github.com> Date: Wed, 10 Jul 2019 13:35:04 -0500 Subject: [PATCH] Silences compiler warnings by fixing small issues Adds explicit `dyn` to lazy_loader.rs, and removes a few unnecessary mut's. --- src/ui/popupmenu/lazy_loader.rs | 3 ++- src/ui/popupmenu/popupmenu.rs | 2 +- src/ui/ui.rs | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ui/popupmenu/lazy_loader.rs b/src/ui/popupmenu/lazy_loader.rs index c5bf0942..ee0db19b 100644 --- a/src/ui/popupmenu/lazy_loader.rs +++ b/src/ui/popupmenu/lazy_loader.rs @@ -19,7 +19,8 @@ struct State { /// Once we're loaded some (or all) data, this closure gets called if /// one exists. The first value in the tuple can is indication on the /// number of items needed before calling the closure. - once_loaded: Option<(Option, Box)>)>, + once_loaded: + Option<(Option, Box)>)>, list: gtk::ListBox, css_provider: gtk::CssProvider, diff --git a/src/ui/popupmenu/popupmenu.rs b/src/ui/popupmenu/popupmenu.rs index b2a6b6b8..83125898 100644 --- a/src/ui/popupmenu/popupmenu.rs +++ b/src/ui/popupmenu/popupmenu.rs @@ -426,7 +426,7 @@ impl Popupmenu { list.select_row(&item.row); { - let mut id = Arc::new(ThreadGuard::new(None)); + let id = Arc::new(ThreadGuard::new(None)); let id_ref = id.clone(); let list = list.clone(); // Ensure that the row is in the view, but make sure first diff --git a/src/ui/ui.rs b/src/ui/ui.rs index 6285d462..338cf3af 100644 --- a/src/ui/ui.rs +++ b/src/ui/ui.rs @@ -391,7 +391,7 @@ fn handle_request( Request::CursorTooltipStyles => { let styles = state.cursor_tooltip.get_styles(); - let mut res: Vec = + let res: Vec = styles.into_iter().map(|s| s.into()).collect(); Ok(res.into())