From 41f91c0480e42011425338e8bc918cd4f650174d Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Mon, 12 Feb 2024 20:36:42 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- lib/Differentiator/CladUtils.cpp | 2 +- lib/Differentiator/ReverseModeVisitor.cpp | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/Differentiator/CladUtils.cpp b/lib/Differentiator/CladUtils.cpp index 775e40776..459a07854 100644 --- a/lib/Differentiator/CladUtils.cpp +++ b/lib/Differentiator/CladUtils.cpp @@ -634,7 +634,7 @@ namespace clad { } void SetSwitchCaseSubStmt(SwitchCase* SC, Stmt* subStmt) { - if (auto caseStmt = dyn_cast(SC)) + if (auto *caseStmt = dyn_cast(SC)) caseStmt->setSubStmt(subStmt); else cast(SC)->setSubStmt(subStmt); diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp index 647b7a4bd..ca4e153e1 100644 --- a/lib/Differentiator/ReverseModeVisitor.cpp +++ b/lib/Differentiator/ReverseModeVisitor.cpp @@ -3296,10 +3296,10 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, condExpr = GlobalStoreAndRef(condDiff.getExpr(), "_cond").getExpr(); } - auto activeBreakContHandler = PushBreakContStmtHandler( + auto *activeBreakContHandler = PushBreakContStmtHandler( /*forSwitchStmt=*/true); activeBreakContHandler->BeginCFSwitchStmtScope(); - auto SSData = PushSwitchStmtInfo(); + auto *SSData = PushSwitchStmtInfo(); if (isInsideLoop) SSData->switchStmtCond = condTape->Last(); @@ -3350,8 +3350,8 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, // ``` if (SSData->defaultIfBreakExpr) { Expr* breakCond = nullptr; - for (auto SC : SSData->cases) { - if (auto CS = dyn_cast(SC)) { + for (auto *SC : SSData->cases) { + if (auto *CS = dyn_cast(SC)) { if (breakCond) { breakCond = BuildOp(BinaryOperatorKind::BO_LAnd, breakCond, BuildOp(BinaryOperatorKind::BO_NE, @@ -3407,7 +3407,7 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context, Expr* lhsClone = (CS->getLHS() ? Clone(CS->getLHS()) : nullptr); Expr* rhsClone = (CS->getRHS() ? Clone(CS->getRHS()) : nullptr); - auto newSC = clad_compat::CaseStmt_Create(m_Sema.getASTContext(), lhsClone, + auto *newSC = clad_compat::CaseStmt_Create(m_Sema.getASTContext(), lhsClone, rhsClone, noLoc, noLoc, noLoc); Expr* ifCond = BuildOp(BinaryOperatorKind::BO_EQ, newSC->getLHS(),