Check in usd-sys bindings

[Jasper-Bekkers]

Right now when doing a clean checkout of this repository and building the rust project you're faced with this error:

error: failed to load manifest for workspace member `/home/jasper/vfx-rs/usd-bind/usd-rs/crates/usd`

Caused by:
  failed to load manifest for dependency `usd-cppstd`

Caused by:
  failed to load manifest for dependency `usd-sys`

Caused by:
  failed to read `/home/jasper/vfx-rs/usd-bind/build/usd-sys/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

For most of the Rust projects that we've maintained, we've checked in the -sys crate so that it's a lot easier for people to get up and running with the crate, and one can do a local checkout pretty easily without having to have a complex build environment.

Another implication of the way it's set up now, is that one can't easily patch the published crate with a local one through the [patch.crates-io] in Cargo.toml and quickly iterate / do fixes.

Usually what we do is we automate the process of generating the bindings through a simple Rust project that's manually invoked. Examples include https://github.com/MaikKlein/ash and https://github.com/gfx-rs/rspirv

[scott-wilson]

This is something that we have discussed in the past. I think we're planning on doing it, but I'm not 100% sure. Although, one thing we are doing to help make it easier to develop on (if you're using Visual Studio Code and it's container plugin) is setting up a Docker container where you just need to build and then you should have all the dependencies set up so you can start building away.

…

On Fri, Oct 15, 2021, 6:33 AM Jasper Bekkers ***@***.***> wrote: Right now when doing a clean checkout of this repository and building the rust project you're faced with this error: error: failed to load manifest for workspace member `/home/jasper/vfx-rs/usd-bind/usd-rs/crates/usd` Caused by: failed to load manifest for dependency `usd-cppstd` Caused by: failed to load manifest for dependency `usd-sys` Caused by: failed to read `/home/jasper/vfx-rs/usd-bind/build/usd-sys/Cargo.toml` Caused by: No such file or directory (os error 2) For most of the Rust projects that we've maintained, we've checked in the -sys crate so that it's a lot easier for people to get up and running with the crate, and one can do a local checkout pretty easily without having to have a complex build environment. Usually what we do is we automate the process of generating the bindings through a simple Rust project that's manually invoked. Examples include https://github.com/MaikKlein/ash and https://github.com/gfx-rs/rspirv — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVFQOGH5WE6JEJ4ZCBGURDUHAURPANCNFSM5GB7UIWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Jasper-Bekkers]

Having a docker container is a nice workaround and potentially a decent workflow for manually updating the -sys bindings - but it still deviates quite a bit from the regular cargo build workflow that is ubiquitous amongst rust projects and I see very little reason to deviate from this for this particular case tbh.

[scott-wilson]

Right. The end goal is to make building and developing as easy as possible, but we're not exactly there yet. This is something that we need to address.

…

On Fri, Oct 15, 2021, 8:31 AM Jasper Bekkers ***@***.***> wrote: Having a docker container is a nice workaround - but it still deviates quite a bit from the regular cargo build workflow that is ubiquitous amongst rust projects and I see very little reason to deviate from this for this particular case tbh. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVFQOFAHM2GLEE3OVXUSM3UHBCNHANCNFSM5GB7UIWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Jasper-Bekkers]

Would you accept a PR to make it more in line with conical rust build steps?

[anderslanglands]

Hi Jasper we will indeed have pre-bound -sys either in this repo or as separate repos (still some discussion about that but see the openexr-bind/-sys/-rs repos). USD Is just in very early stages and not intended for public consumption just yet.

…

On Sat, 16 Oct 2021 at 06:39, Jasper Bekkers ***@***.***> wrote: Would you accept a PR to make it more in line with conical rust build steps? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOYQXNH4XOHWLOOBV5D4OTUHBRLVANCNFSM5GB7UIWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[luke-titley]

done