New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making some libffi build options configurable #2

Open

alexrp opened this issue Jul 2, 2024 · 2 comments

Labels

area: build state: approved

Member

alexrp commented Jul 2, 2024

libffi/build.zig

Line 293 in 83a2593

.FFI_DEBUG = null, // TODO: Perhaps make this configurable.

libffi/build.zig

Line 299 in 83a2593

.FFI_MMAP_EXEC_EMUTRAMP_PAX = null, // TODO: Perhaps make this configurable.

libffi/build.zig

Line 304 in 83a2593

.FFI_NO_RAW_API = null, // TODO: Perhaps make this configurable.

libffi/build.zig

Line 305 in 83a2593

.FFI_NO_STRUCTS = null, // TODO: Perhaps make this configurable.

alexrp added area: build state: deliberation type: feature labels

Member Author

alexrp commented Jul 17, 2024

FFI_DEBUG

This seems to mostly be for internal libffi debugging purposes, so not that useful.

FFI_NO_RAW_API

I decided not to bind the raw API as it's undocumented and (AFAICT) never really used in the wild. So this option doesn't matter.

FFI_NO_STRUCTS

No idea why anyone would want this. It doesn't even significantly reduce code size.

Member Author

alexrp commented Jul 17, 2024

FFI_MMAP_EXEC_EMUTRAMP_PAX

This seems useful for Gentoo/PaX. Should be added, but off by default.

alexrp added state: approved and removed state: deliberation labels

alexrp removed the type: feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment