Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid tutorial #3194

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Hybrid tutorial #3194

merged 14 commits into from
Aug 26, 2024

Conversation

jobergum
Copy link
Member

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@jobergum jobergum marked this pull request as draft May 15, 2024 16:49
@jobergum jobergum requested a review from andreer August 21, 2024 11:55
@jobergum
Copy link
Member Author

@andreer since you have some experience with hybrid search questions :) I'll ask you to review, this is no way perfect, but maybe a start.

@jobergum jobergum marked this pull request as ready for review August 21, 2024 12:10
@andreer
Copy link
Member

andreer commented Aug 23, 2024

This is great. A few comments:

It would be good to include a little bit of motivation in the start - "we will later see that using hybrid search to combine both methods leads to better results than using only embeddings or text matching" or something

python module "requests" is required but not installed (I'm sure most have it but still)

the content cluster capacity can be increased by adding node elements ...
move this down to nodes?

services.xml is missing root tag , and "main" becomes just "main", at least here in the github markdown preview - make sure this becomes correctly copy-pastable in the doc

I suggest sending this also to review by someone new to search/hybrid search like @esolitos :-)

Copy link
Contributor

@esolitos esolitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not extremely familiar yet with all the terminology and relevancy algos, but I was able to follow the tutorial.

I left a couple of comments here and there, but this looks good. 😊

I noticed some slightly different relevancy scores in some commands, but I am not sure if that is relevant.

en/tutorials/hybrid-search.md Outdated Show resolved Hide resolved
en/tutorials/hybrid-search.md Outdated Show resolved Hide resolved
en/tutorials/hybrid-search.md Show resolved Hide resolved
en/tutorials/hybrid-search.md Outdated Show resolved Hide resolved
@jobergum jobergum merged commit 4c7dd2a into master Aug 26, 2024
1 of 2 checks passed
@jobergum jobergum deleted the hybrid-tutorial branch August 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants