-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hybrid tutorial #3194
Hybrid tutorial #3194
Conversation
@andreer since you have some experience with hybrid search questions :) I'll ask you to review, this is no way perfect, but maybe a start. |
This is great. A few comments: It would be good to include a little bit of motivation in the start - "we will later see that using hybrid search to combine both methods leads to better results than using only embeddings or text matching" or something python module "requests" is required but not installed (I'm sure most have it but still)
services.xml is missing root tag , and "main" becomes just "main", at least here in the github markdown preview - make sure this becomes correctly copy-pastable in the doc I suggest sending this also to review by someone new to search/hybrid search like @esolitos :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not extremely familiar yet with all the terminology and relevancy algos, but I was able to follow the tutorial.
I left a couple of comments here and there, but this looks good. 😊
I noticed some slightly different relevancy scores in some commands, but I am not sure if that is relevant.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.