Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more secure cryptographic hashing function for password instead of the current MD5 #5769

Open
allanbenW opened this issue Nov 22, 2023 · 3 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@allanbenW
Copy link

Introduction

NebulaGraph (as of v3.6.0) uses MD5 for password hashing

proxygen::md5Encode(folly::StringPiece(*cuNode->password())),

However, MD5 is known to have a broken collision resistance and is vulnerable to collision attacks. There are also published theoretical attacks against its preimage resistance.

Contents

Use a cryptographically secure hashing function, such as bcrypt

Related work

@allanbenW allanbenW added the type/enhancement Type: make the code neat or more efficient label Nov 22, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Nov 23, 2023

Welcome @allanbenW to the community and thanks for pointing this out!

@dutor @MuYiYong

@allanbenW
Copy link
Author

Hi team. Just wondering if there's any plan addressing this security concern soon? maybe next (few) minor/major release?

@allanbenW
Copy link
Author

bump again

apologize for ping, just trying to get some attention
@wey-gu @dutor

this is a security concern flagged by our security team, and it's blocking our adoption of this otherwise amazing solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

2 participants