Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventbus bridge should have Auth message type #75

Open
EmadAlblueshi opened this issue May 10, 2023 · 0 comments
Open

Eventbus bridge should have Auth message type #75

EmadAlblueshi opened this issue May 10, 2023 · 0 comments

Comments

@EmadAlblueshi
Copy link

What is the feature ?

The Eventbus bridge should have an Authentication message type because it's a bridge to Vert.x "Internal" messaging system. The great thing here is that Vert.x has a broad range of authentication providers and we can use them conveniently.

I emphasize that the bridge should implement authentication per connection only like what Vert.x STOMP Server already has and once the authentication is successful the client can utilize other message types to communicate as mentioned in the documentation and if it fails then send back an error message and close the connection directly.

We should support this feature to any transport like TCP, WebSocket ,SockJs and others.

Why ?

Security control from malicious attacks and any other security concerns.

What else ?

I believe we should rename the package to something like eventbus-bridge and of course the default implementation for TCP transport in addition we add SockJS event bus bridge and WebSocket event bus bridge too.

Can you contribute to this feature ?

Yes of course with little guidance from the community and the core team.

Final notes

I have developed a simpler implementation than the current and works for TCP and WebSocket with the Auth message type but we need to have further discussion before proceeding any further.

Thanks.

@tsegismont @vietj @pmlopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants