Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume an event bus message has an address property #22

Open
lance opened this issue Dec 18, 2013 · 0 comments
Open

Don't assume an event bus message has an address property #22

lance opened this issue Dec 18, 2013 · 0 comments
Assignees
Labels
Milestone

Comments

@lance
Copy link
Contributor

lance commented Dec 18, 2013

This commit breaks backwards compatibility.

#7

The fix requires that the event bus always call jMsg.address(), which hasn't always existed. Therefore, with older versions of vert.x users will see this message.

org.dynjs.exception.ThrowException: TypeError: not callable: [DerefRef: value=undefined; ref=[Reference: name=address; base=org.vertx.java.core.eventbus.impl.JsonObjectMessage@809f86c (org.vertx.java.core.eventbus.impl.JsonObjectMessage)]]

This would cause breakage for users of lang-rhino 2.0.0-final or any recent SNAPSHOT of lang-rhino or lang-dynjs who upgrade their language module to 2.1 for rhino or 1.0 for dynjs, but don't update their vert.x. Admittedly a silly thing to do, but there you go.

@ghost ghost assigned lance Dec 18, 2013
@lance lance modified the milestones: 1.1.0, 1.0.0 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant