The game doesn't list integrated components

[royfalk]

This was OK before, as the engine treated the unit as a single struct and worked on it. Now, we need to list these missing components.

[evertvorster]

The current master also does not deal with special packages properly.
Since this code is getting touched, there may be an opportunity to fix components properly for once and for all.

My issue is that I bought a .milspec ship, and sold the milspec package. This should turn the ship into a .stock ship, right?
Unfortunately this does not happen, and now the game engine is acting a little confused about which components are on the ship. The components that I bought to replace the milspec package shows up on some branches of the engine, and not on others.

I think listing integrated components is a good way to go.

ie: when you first get a ship, the components in it is generated from a template, but then as soon as you save it, every component is in that save file, and as you modify your ship, the modifications go back into the save file. ie: never read the template again for the ship.

[royfalk]

The current master also does not deal with special packages properly.

It never did.

Since this code is getting touched, there may be an opportunity to fix components properly for once and for all.

That's the plan.

My issue is that I bought a .milspec ship, and sold the milspec package. This should turn the ship into a .stock ship, right?

I don't know. It depends on the design we settle on. In my view, buying a milspec ship comes with a bigger engine, beefier armor, etc. You couldn't downgrade that and you couldn't buy or sell a package that turns one into the other.

But that's my view of things. Really, I'm not a fan of variants at all. The game has too many ships as it is and adding variants doesn't really do anything to improve it. Also, having a milspec variant of a military vessel sounds silly.

I think listing integrated components is a good way to go.

It's the only way to go if you want to see the damage to these components and repair it. Right now, you can have a nearly dead capital ship and repair everything there with the standard repair and refuel for 4500 credits.

... never read the template again for the ship.

This will be the case when we merge #1005 .

[evertvorster]

Using variants makes the game more interesting, because you never really know if the next ship you meet is completely standard, or will be a little more difficult to take down.

Saying that, I think the implementation of it is wrong.

This is my opinion only, but ship types should be unique. The variation should come from the components installed in them.
As such, "milspec" should just mean a set of components installed on a stock variant. So, it should not be reflected in the name of the ship, but rather the components in the ship. If selling the "milspec" package, you should be left with a stock ship.

Variants of a popular ship could still exist, but then they need to be shaped and painted slightly differently.

[royfalk]

This is my opinion only, but ship types should be unique. The variation should come from the components installed in them.
As such, "milspec" should just mean a set of components installed on a stock variant. So, it should not be reflected in the name of the ship, but rather the components in the ship. If selling the "milspec" package, you should be left with a stock ship.

I completely agree.