Overdrive missing Upgrade_Type field

[royfalk]

All overdrive upgrades are missing the Upgrade_Type field.
Without "Upgrade_Type": "Afterburner_Upgrade", the upgrade isn't applied.

[royfalk]

This appears to have been fixed by vegastrike/Assets-Production@64d39e5. I'm not sure what's going on here.

[kheckwrecker]

As requested, I'm replying to :

"The problem with overdrives not working after upgrades adds a bit to the problem (since you can't afterburn into docking range) but I see there's a patch in testing to fix that problem.

I opened an issue for it after discovering it myself and then discovered I fixed it a month back. Can you reply on #55 with information about your game? What branches are you on and what ship are you flying."

I refreshed my build of both master and assets as of 30 minutes ago, and I'm flying a Progeny. Just to make sure my report is correct, I tried launching, set my speed to maximum and then triggered my overdrive. Instead of not working, my speed actually dropped from 340 to 189 and then returned to 340 when I released the overdrive key. I don't know if the same problem as previously reported, or a different problem.

BTW, I have an Overdrive III.

[royfalk]

Please save the game and upload the ship file with the upgrade. It should be:
/serialized_xml//progeny.json or something similar.

[kheckwrecker]

Here you go... (hope this works)

Progeny.rgspec.json

[kheckwrecker]

Also have a Dostoevsky in my hangar if you're interested...

Dostoevsky.stock.json

[royfalk]

It's a different bug.

Base afterburner is 340.
Overdrive 3:
"Afterburner_Speed_Governor": "1.8"

340 / 1.8 = 189

[kheckwrecker]

I'm assuming that should be 340 * 1.8 = 612? Should I report that bug? Assets or Engine?

[kheckwrecker]

BTW, in the repository, there's an Assets-Production and an Assets-Master. I've always used Assets-Production for testing. Which should I be using, and what's the difference between the two?

[royfalk]

I'm assuming that should be 340 * 1.8 = 612?

Yes.

Should I report that bug? Assets or Engine?

This issue is the bug. You don't need to open a new one.

BTW, in the repository, there's an Assets-Production and an Assets-Master.
I've always used Assets-Production for testing. Which should I be using, and what's the difference between the two?

Asset-Master contains the high resolution pictures and other source material. Asset-Production is used to run the game. You open issues in master and play the game with production.