From 635d54cf4cbb4fbbf2e78f1d947f575e95133897 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marius=20B=C3=B6rschig?= Date: Tue, 29 Oct 2024 11:38:03 +0100 Subject: [PATCH 1/2] cmake: don`t split debug symbols off of static libs --- SilKit/cmake/SilKitBuildTools.cmake | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/SilKit/cmake/SilKitBuildTools.cmake b/SilKit/cmake/SilKitBuildTools.cmake index 8b3ad0343..7568951f1 100644 --- a/SilKit/cmake/SilKitBuildTools.cmake +++ b/SilKit/cmake/SilKitBuildTools.cmake @@ -17,7 +17,6 @@ macro(silkit_split_debugsymbols targetName) ) endmacro() - macro(silkit_package_debugsymbols targetName) if(MSVC) message(STATUS "Creating symbol package ${SILKIT_SYMBOLS_DIR_NAME}") @@ -33,6 +32,11 @@ macro(silkit_package_debugsymbols targetName) return() endif() if(UNIX AND CMAKE_BUILD_TYPE MATCHES "Debug") + get_target_property(targetType ${targetName} TYPE) + if(targetType STREQUAL STATIC_LIBRARY) + message(STATUS "SIL Kit: splitting debug symbols on static libraries is not supported") + return() + endif() silkit_split_debugsymbols("${targetName}") From 65efe035532bd4d8b6690c9310e2c6874baf18b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marius=20B=C3=B6rschig?= Date: Tue, 29 Oct 2024 12:01:18 +0100 Subject: [PATCH 2/2] fixup! cmake: don`t split debug symbols off of static libs --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7a8a44f0d..e3b87605b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -38,7 +38,7 @@ option(SILKIT_ENABLE_UBSAN "Enable -f sanitize=undefined for builds (requires gc option(SILKIT_ENABLE_THREADSAN "Enable -f sanitize=thread for builds (requires gcc, clang)" OFF) option(SILKIT_ENABLE_COVERAGE "Enable coverage for builds (requires gcc, clang)" OFF) option(SILKIT_WARNINGS_AS_ERRORS "Treat compiler warnings as errors" OFF) -option(SILKIT_PACKAGE_SYMBOLS "Add a post-build step to create PDB/Symbol archives" ON) +option(SILKIT_PACKAGE_SYMBOLS "Add a post-build step to create PDB/Symbol archives" OFF) option(SILKIT_BUILD_DASHBOARD "Build the SIL Kit Dashboard client." ON) option(SILKIT_ENABLE_TRACING_INSTRUMENTATION "Enable tracing instrumentation (_SILKIT_TRACE_CLASS_NAMES)." OFF) option(SILKIT_LINK_LLD "Use the lld linker for SIL KIT" OFF)