From 3c52360a35ab16cb34f259087307647085a33b8e Mon Sep 17 00:00:00 2001 From: Daniel Edwards Date: Wed, 30 Oct 2024 12:12:50 +0100 Subject: [PATCH] fixup! config: allow overriding rpc and pub/sub labels Co-authored-by: KonradBkd <117755498+KonradBkd@users.noreply.github.com> --- SilKit/IntegrationTests/ITest_Internals_DataPubSub.cpp | 2 +- SilKit/IntegrationTests/ITest_Internals_Rpc.cpp | 2 +- docs/configuration/services-configuration.rst | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/SilKit/IntegrationTests/ITest_Internals_DataPubSub.cpp b/SilKit/IntegrationTests/ITest_Internals_DataPubSub.cpp index da66fbeb5..5f5287031 100644 --- a/SilKit/IntegrationTests/ITest_Internals_DataPubSub.cpp +++ b/SilKit/IntegrationTests/ITest_Internals_DataPubSub.cpp @@ -501,7 +501,7 @@ TEST_F(ITest_Internals_DataPubSub, test_1pub_1sub_sync_mixed_labels) RunSyncTest(pubsubs); } -// Matching mandatory labels +// Matching mandatory labels provided by a participant configuration TEST_F(ITest_Internals_DataPubSub, test_1pub_1sub_sync_label_override) { const uint32_t numMsgToPublish = defaultNumMsgToPublish; diff --git a/SilKit/IntegrationTests/ITest_Internals_Rpc.cpp b/SilKit/IntegrationTests/ITest_Internals_Rpc.cpp index d2a8f2761..1d1825fc8 100644 --- a/SilKit/IntegrationTests/ITest_Internals_Rpc.cpp +++ b/SilKit/IntegrationTests/ITest_Internals_Rpc.cpp @@ -297,7 +297,7 @@ TEST_F(ITest_Internals_Rpc, test_1client_1server_sync_labels) RunSyncTest(rpcs); } -// Matching mandatory and optional labels on both sides +// Matching mandatory and optional labels on both sides provided by a participant configuration TEST_F(ITest_Internals_Rpc, test_1client_1server_sync_label_override) { const uint32_t numCallsToReceive = defaultNumCalls; diff --git a/docs/configuration/services-configuration.rst b/docs/configuration/services-configuration.rst index f94cb0274..48d69e170 100644 --- a/docs/configuration/services-configuration.rst +++ b/docs/configuration/services-configuration.rst @@ -156,6 +156,7 @@ DataPublishers - The topic on which the data publisher publishes its information. (optional) * - Labels - The labels determining matching subscribers with the same topic and media type. (optional) + Note that these labels will replace all programmatically provided labels. .. _sec:cfg-participant-data-subscribers: