Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): Function for Converting Character Encodings #1155

Closed
powerumc opened this issue Dec 1, 2024 · 2 comments · Fixed by #1162
Closed

feat(stdlib): Function for Converting Character Encodings #1155

powerumc opened this issue Dec 1, 2024 · 2 comments · Fixed by #1162
Labels
type: feature A value-adding code addition that introduce new functionality.

Comments

@powerumc
Copy link
Contributor

powerumc commented Dec 1, 2024

Our system utilizes both legacy systems and the latest Linux distributions. Occasionally, we encounter systems that operate with non-UTF-8 settings. When logs are sent via TCP from these systems, all Korean strings encoded in EUC-KR become corrupted.

To address this issue, I've created a functions.
The function signature is as follows.

decode_charset(value, from_charset)
encode_charset(value, to_charset)

If this addition is beneficial for the VRL project, I would like to submit a pull request.

@pront pront added the type: feature A value-adding code addition that introduce new functionality. label Dec 2, 2024
@pront
Copy link
Member

pront commented Dec 2, 2024

Hi @powerumc, thank you for creating this issue.

This sound like a generic version to process chars and it could eventually replace functions like the following:

In general, this sounds like a good idea, and we would be happy to review your PR.

@powerumc
Copy link
Contributor Author

powerumc commented Dec 3, 2024

I have created a PR for this issue. #1162
I would appreciate your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants