Skip to content

Provide Event::iter and Event::iter_mut functions that yield (Lookup, Value). #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hoverbear opened this issue Jun 17, 2020 · 2 comments
Closed

Provide Event::iter and Event::iter_mut functions that yield (Lookup, Value). #2845

Hoverbear opened this issue Jun 17, 2020 · 2 comments
Labels
domain: data model Anything related to Vector's internal data model domain: logs Anything related to Vector's log events type: tech debt A code change that does not add user value.

Comments

@Hoverbear
Copy link
Contributor

Hoverbear commented Jun 17, 2020 •
edited
Loading

Step 8 of https://github.com/timberio/vector/blob/c4707947bd876a0ff7d7aa36717ae2b32b731593/rfcs/2020-05-25-more-usable-logevents.md#sales-pitch.

Remove the Event::all_fields function.

Include tests against https://github.com/timberio/vector/blob/c4707947bd876a0ff7d7aa36717ae2b32b731593/rfcs/2020-05-25-more-usable-logevents.md#a-motivatingly-complex-example

Depends on #2843
@Hoverbear Hoverbear added this to the Usable Events milestone Jun 17, 2020
@binarylogic binarylogic added the type: tech debt A code change that does not add user value. label Jun 19, 2020
@Hoverbear
Copy link
Contributor Author

@lukesteensen this might be related to #3074 ?

@binarylogic binarylogic removed this from the Usable Events milestone Jul 19, 2020
@binarylogic binarylogic added domain: data model Anything related to Vector's internal data model and removed domain: ux labels Jul 29, 2020
@binarylogic binarylogic added domain: logs Anything related to Vector's log events and removed event type: log labels Aug 6, 2020
@Hoverbear Hoverbear changed the title Provide Event::iter and Event::iter_mut functions that yield (Path, Value). Provide Event::iter and Event::iter_mut functions that yield (Lookup, Value). Sep 30, 2020
@Hoverbear Hoverbear mentioned this issue Dec 3, 2020
Closed
3 tasks
@binarylogic binarylogic assigned JeanMertz and unassigned Hoverbear Feb 22, 2021
@binarylogic binarylogic modified the milestones: 2020-12-07: Nanite Repair System, 2021-02-22 - Scottish Deerhound Feb 22, 2021
@JeanMertz JeanMertz removed their assignment Mar 26, 2021
@jszwedko
Copy link
Member

jszwedko commented Aug 2, 2022

Closing since we ended up introducing a new implementation for lookups.

@jszwedko jszwedko closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: data model Anything related to Vector's internal data model domain: logs Anything related to Vector's log events type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement: Use new Lookup accessors on LogEvents and entire internal API. vectordotdev/vector
5 participants
@jamtur01 @Hoverbear @jszwedko @JeanMertz @binarylogic