-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes_log
source: Specify a user agent when making requests to the k8s api server
#21864
Comments
kubernetes_log
source does not specify a user agent when making requests of the k8s api serverkubernetes_log
source: Specify a user agent when making requests to the k8s api server
I have a branch on which I've put together a proposed fix; I'm working through the contributions documentation to bring it up to snuff, but if you want a sneak peak you can find it here: master...ganelo:vector:og/kubernetes-user-agent |
Awesome, this seems to be on the right track! |
Thanks @ganelo, I was about to comment that this request seems reasonable and we can add this header. Don't hesitate to open a PR! |
Apologies for the delay, I realized that my testing had been exclusively focused on verifying that the header was coming through, but in practice the changes on my branch resulted in the kubernetes logs not being picked up, suggesting some fundamental issue with the approach. I'm going to be trying to get to the bottom of this next week, but odds are it will bleed into the following week given that next week is Thanksgiving. |
Found/fixed the issue (minor oversight - wasn't actually handing the InitDone events to the store). PR here: #21905 |
Closed by #21905 |
Looking at logs generated by k8s-audit-webhook, I can see that when vector requests the set of pods from the k8s api server, it is not specifying a user agent. This makes it difficult to attribute load on the api server to the correct client (namely, vector).
The text was updated successfully, but these errors were encountered: