Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Server keepalive.max_connection_age_secs can't be set to null #19644

Closed
andrewma2 opened this issue Jan 17, 2024 · 0 comments · Fixed by #19802
Closed

HTTP Server keepalive.max_connection_age_secs can't be set to null #19644

andrewma2 opened this issue Jan 17, 2024 · 0 comments · Fixed by #19802
Labels
source: http_server Anything `http_server` source related type: bug A code related bug.

Comments

@andrewma2
Copy link

andrewma2 commented Jan 17, 2024

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

According to the update guide the newly added keepalive feature for HTTP server sources can be disabled by setting keepalive.max_connection_age_secs to null.

However, vector hits a parse error when we set this value in our JSON config (says it encountered an invalid TOML value despite us passing a JSON config)

Configuration

Basic test config (file called `vector.json`)


{
	"sources": {
		"http": {
			"address": "0.0.0.0:443",
			"type": "http_server",
			"keepalive": {
				"max_connection_age_secs": null
			}
		}
	},
	"sinks": {
		"blackhole": {
			"inputs": ["http"],
			"type": "blackhole"
		}
	}
}

Version

0.35.0

Debug Output

Running
`vector --config vector.json`

produces this output 

2024-01-17T19:46:11.429210Z  INFO vector::app: Log level is enabled. level="info"
2024-01-17T19:46:11.434724Z  INFO vector::app: Loading configs. paths=["vector.json"]
2024-01-17T19:46:11.442812Z ERROR vector::cli: Configuration error. error=invalid type: null, expected any valid TOML value at line 7 column 35

Example Data

No response

Additional Context

Initial support thread on Discord

References

No response

@andrewma2 andrewma2 added the type: bug A code related bug. label Jan 17, 2024
@jszwedko jszwedko added the source: http_server Anything `http_server` source related label Jan 18, 2024
@jszwedko jszwedko added this to the Vector v0.35.1 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: http_server Anything `http_server` source related type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants