Keepalive with HTTP2 triggers a lot of logs

[andrewma2]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

After upgrading to 0.35, we start to see a lot of logs like

{"host":"vector-aggregator-0","message":"Connection header illegal in HTTP/2: connection","metadata":{"kind":"event","level":"WARN","module_path":"hyper::proto::h2","target":"hyper::proto::h2"},"pid":1,"source_type":"internal_logs","timestamp":"2024-01-16T23:20:59.694834689Z"}

We're using an http_server source with an HTTP2 connection. Setting keepalive.max_connection_age_secs to a high value, we no longer see these logs. This leads us to think that this issue arises from the new keepalive feature for HTTP server sources sending with the Connection header which is not accepted in HTTP2.

Configuration

Adding http_server source config (with some parts obscured)

"http": {
            "address": XXX,
            "decoding": {
                "codec": "protobuf",
                "protobuf": {
                    XXX
                }
            },
            "framing": {
                "method": "bytes"
            },
            "headers": [

            ],
            "tls": {
                "alpn_protocols": [
                    "h2"
                ],
                "ca_file": XXX,
                "crt_file": XXX,
                "enabled": true,
                "key_file": XXX,
                "verify_certificate": false
            },
            "type": "http_server"
        }

Version

0.35.0

Debug Output

No response

Example Data

No response

Additional Context

Initial thread on support channel in Discord

References

No response