Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate fslock usage #19631

Open
pront opened this issue Jan 16, 2024 · 0 comments
Open

Investigate fslock usage #19631

pront opened this issue Jan 16, 2024 · 0 comments

Comments

@pront
Copy link
Member

pront commented Jan 16, 2024

This discussion originates from this PR.

Reproduction

  1. Checkout this branch.

  2. In one terminal run:

cargo run --package vector --bin vector --  -w --config /Users/pavlos.rontidis/CLionProjects/vector/pront_tests/vector/configs/lock.yaml
  1. In a second terminal run:
cargo run --package vector --bin vector --  -w --config /Users/pavlos.rontidis/CLionProjects/vector/pront_tests/vector/configs/lock.yaml

Result: Both instances run.

Whereas with fs4 the second instance won't start:

2024-01-16T15:13:20.065037Z ERROR vector::cli: Configuration error. error=Couldn't lock "/Users/pavlos.rontidis/CLionProjects/vector/pront_tests/data_dir/.lock". Error: Resource temporarily unavailable (os error 35)

^ which is the desired behavior.

Note

We might be able to delete the fslock usage altogether after this #19612 is done. So we can repurpose this work to an upgrade plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant