Vector disk buffer pre-maturely ack to source

[anil-db]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

When using disk buffer, record.encode in writer.ts moves the record and drop it causing acknowledgement to happen to source.
but record is not written to disk so such ack are premature.

record should not dropped here and same record should be returned incase of any error happened rather than decoded one.

Configuration

No response

Version

35.0

Debug Output

No response

Example Data

No response

Additional Context

To repro we need to create the situation where disk write fail after encoding of record, which is probably easier to in a unit test.

References

No response

[jszwedko]

Thanks for filing this. I would like to see a test (agreed a unit test would be good) that shows the failure.

[anil-db]

Thanks for filing this. I would like to see a test (agreed a unit test would be good) that shows the failure.

I created this PR with unit test #19650 which shows the issue.