Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEmoji doesn't work for emojis with gender modifiers #137

Open
4ver opened this issue Sep 5, 2019 · 2 comments
Open

isEmoji doesn't work for emojis with gender modifiers #137

4ver opened this issue Sep 5, 2019 · 2 comments

Comments

@4ver
Copy link

4ver commented Sep 5, 2019

Passing πŸƒβ€β™‚οΈor πŸƒβ€β™€οΈto isEmoji returns false.

@vdurmont
Copy link
Owner

vdurmont commented Sep 9, 2019

This is true, I wrote a quick test that is failing. I'm going to try to investigate but if you have time, a PR is always welcome!

@Test
  public void isEmoji_with_gender_modifier_returns_true() {
    // GIVEN
    String str = "πŸƒβ€β™‚";

    // WHEN
    boolean isEmoji = EmojiManager.isEmoji(str);

    // THEN
    assertTrue(isEmoji);
  }

@sullis
Copy link
Contributor

sullis commented Sep 10, 2019

Draft Pull Request: #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants