Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite-plugin v4.0.2 does not work with Remix #1311

Closed
2 tasks done
MattyBalaam opened this issue Feb 4, 2024 · 3 comments
Closed
2 tasks done

vite-plugin v4.0.2 does not work with Remix #1311

MattyBalaam opened this issue Feb 4, 2024 · 3 comments
Labels
bug Issue is caused by a bug in a Vanilla Extract package remix issue related to the remix integration vite Issue related to vite

Comments

@MattyBalaam
Copy link

MattyBalaam commented Feb 4, 2024

Describe the bug

Trying to use 4.0.2 with remix throws an error "The Remix Vite plugin requires the use of a Vite config file"

I have seen the issue with yarn 1, yarn 4 (where I first encountered as part of a monorepo) and npm

Screenshot 2024-02-04 at 10 46 10

I have a reproduction - just install and run the dev script

It works if you revert back to 4.0.0

Reproduction

https://github.com/MattyBalaam/remix-vanilla-4.0.2-issue

System Info

System:
    OS: macOS 14.3
    CPU: (11) arm64 Apple M3 Pro
    Memory: 86.91 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - /opt/homebrew/opt/node@18/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.1 - /opt/homebrew/opt/node@18/bin/npm
    pnpm: 8.15.1 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.139
    Safari: 17.3
  npmPackages:
    @vanilla-extract/css: 1.14.1 => 1.14.1 
    @vanilla-extract/vite-plugin: 4.0.2 => 4.0.2

Used Package Manager

npm

Logs

No response

Validations

@askoufis
Copy link
Contributor

askoufis commented Feb 4, 2024

This was fixed in #1308, which should be released soon.

@mrm007 mrm007 added vite Issue related to vite remix issue related to the remix integration bug Issue is caused by a bug in a Vanilla Extract package and removed pending triage labels Feb 4, 2024
@mrm007
Copy link
Contributor

mrm007 commented Feb 4, 2024

This should be fixed in v4.0.3

@MattyBalaam
Copy link
Author

It’s working here for me. Many thanks for super fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is caused by a bug in a Vanilla Extract package remix issue related to the remix integration vite Issue related to vite
Projects
None yet
Development

No branches or pull requests

3 participants