Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: update pyproject.toml #834

Open
siebrenf opened this issue Mar 28, 2022 · 4 comments
Open

FR: update pyproject.toml #834

siebrenf opened this issue Mar 28, 2022 · 4 comments
Labels
enhancement New feature or request stale Period of inactivity

Comments

@siebrenf
Copy link
Member

pip pyproject.toml and setuptools dont work nicely together yet.

I tried to make it work, but entry points and packages aren't implemented/documented properly yet. Here's what I got so far. So at least I didn't waste my afternoon too much.

btw, use validate-pyproject to check the file.

[project]
name = "seq2science"
version = "0.7.2"
description = "seq2science: easy pre-processing of ngs data."
readme = "README.md"
requires-python = ">3.6"
license = {file = "LICENSE"}
authors = [
    {name="Maarten van der Sande", email="[email protected]"},
    {name="Siebren Frölich", email="[email protected]"}
]
keywords = [
    "bioinformatics",
    "RNA-seq",
    "ATAC-seq",
    "ChIP-seq",
    "scRNA-seq",
    "scATAC-seq",
    "snakemake",
]
classifiers = [
    "Development Status :: 5 - Production/Stable",
    "Intended Audience :: Developers",
    "Intended Audience :: Science/Research",
    "License :: OSI Approved :: MIT License",
    "Operating System :: POSIX :: Linux",
    "Operating System :: MacOS :: MacOS X",
    "Programming Language :: Python",
    "Programming Language :: Python :: 3",
    "Topic :: Scientific/Engineering :: Bio-Informatics"]

packages = ["seq2science"]
package_data = "{'seq2science':['envs/*', 'imgs/*', 'rules/*', 'schemas/*', 'schemas/*/*', 'scripts/*', 'scripts/**/*', 'workflows/*/*']}"
include_package_data = true

[project.urls]
documentation = "https://vanheeringen-lab.github.io/seq2science"
repository = "https://github.com/vanheeringen-lab/seq2science"
changelog = "https://github.com/vanheeringen-lab/seq2science/blob/master/CHANGELOG.md"

[project.scripts]
seq2science = "bin/seq2science"
deseq2science = "bin/deseq2science"

[build-system]
requires = ["setuptools==59.4.0", "wheel", "toml"]
build-backend = "setuptools.build_meta"

# flake8 does not support pyproject.toml (yet?!)
# [flake8] ...
@siebrenf siebrenf added the enhancement New feature or request label Mar 28, 2022
@Maarten-vd-Sande
Copy link
Member

I know that the pyproject.toml isn't ideal, we just had a problem with it last week @tilschaef

Maybe we should instead parse the seq2science version from the toml file? I somehow get irky when the version is specified on multiple spots. Or even better we implement something like versioneer, but idk how that plays together with pyproject

@Maarten-vd-Sande
Copy link
Member

Also maybe there is a better way to package? I just like pyproject.toml since I do believe it is the most sensible way to package afaik. However documentation and progress on it is super slow

@Maarten-vd-Sande
Copy link
Member

@siebrenf should we just update it to this? Doesn't hurt I guess right, and it should be an improvement

@stale
Copy link

stale bot commented Jul 10, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale Period of inactivity label Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Period of inactivity
Projects
None yet
Development

No branches or pull requests

2 participants