refactor: if statements in eligible to run method

vanguardbackup · Jun 24, 2024 · ff593ef · ff593ef
1 parent 030402a
commit ff593ef
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/app/Models/BackupTask.php b/app/Models/BackupTask.php
@@ -194,12 +194,13 @@ public function eligibleToRunNow(): bool
         if ($this->isReady() && $this->usingCustomCronExpression()) {
             return $this->cronExpressionMatches();
         }
-
-        if ($this->isReady() && ! $this->usingCustomCronExpression()) {
-            return $this->isTheRightTimeToRun();
+        if (!$this->isReady()) {
+            return false;
         }
-
-        return false;
+        if ($this->usingCustomCronExpression()) {
+            return false;
+        }
+        return $this->isTheRightTimeToRun();
     }
 
     public function cronExpressionMatches(): bool