Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve rules chain inside Validate #156

Open
GooRiOn opened this issue Jan 6, 2018 · 0 comments
Open

Resolve rules chain inside Validate #156

GooRiOn opened this issue Jan 6, 2018 · 0 comments

Comments

@GooRiOn
Copy link
Member

GooRiOn commented Jan 6, 2018

As you see we have a #114 almost done by @paw3lx. However we spotted that this feature requires the whole rules chain to be resolved inside Validate() method since the object is required as a one of the parameter of the selector. This will cause the inconsistency comparing to the previous solution where each chain is resolved inside ValitRules object (more precisely inside Ensure()). Now we have two options:

  1. Move all creations of rules chain to Validate() method to be consistent
  2. Get rid of old overloads which don't require second parameter, so the object (again to be consistent)
@GooRiOn GooRiOn added this to the 1.3.0 milestone Jan 6, 2018
@GooRiOn GooRiOn removed the 1.0.0 label Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant