Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isISO8601): fix for dates with year inferior to 1000 #2519

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(isISO8601): fix for dates with year inferior to 1000 #2519

wants to merge 2 commits into from

Conversation

skpanagiotis
Copy link

@skpanagiotis skpanagiotis commented Jan 19, 2025 •
edited
Loading

Update the isISO8601 function to validate dates which have year inferior to 1000

Add const yearString to construct yearString using slice in case that year is <1000.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

closes #2517

@skpanagiotis skpanagiotis mentioned this pull request Jan 19, 2025
Open
@skpanagiotis skpanagiotis force-pushed the fix-iso8601-inferior-1000 branch from 2c778ca to 7ffcec2 Compare January 19, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isISO8601 does not support dates with year inferior to 1000 in strict mode
1 participant
@skpanagiotis