From 7e67435cd0c0acf14c40584d54d7fe252fde23a1 Mon Sep 17 00:00:00 2001
From: Uladzislau Arlouski <uarlouski@gmail.com>
Date: Thu, 21 Nov 2024 16:15:06 +0200
Subject: [PATCH] just test

---
 .github/workflows/gradle.yml                                | 6 ++++++
 .../browserup/bup/mitmproxy/MitmProxyProcessManager.java    | 3 +--
 .../bup/mitmproxy/management/AddonsManagerClient.java       | 3 +--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
index 98c43d28..7b181c4d 100644
--- a/.github/workflows/gradle.yml
+++ b/.github/workflows/gradle.yml
@@ -43,3 +43,9 @@ jobs:
       run: |
         export MITMPROXY_BINARY_PATH=$(type -aP mitmdump | xargs dirname )
         ./gradlew build -PMITMPROXY_BINARY_PATH="$MITMPROXY_BINARY_PATH"
+
+    - name: Unit tests
+      uses: actions/upload-artifact@v4
+      if: always()
+      with:
+        path: browserup-proxy-core/build/reports/tests
diff --git a/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/MitmProxyProcessManager.java b/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/MitmProxyProcessManager.java
index 8c81f358..ddde0012 100644
--- a/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/MitmProxyProcessManager.java
+++ b/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/MitmProxyProcessManager.java
@@ -5,7 +5,6 @@
 import org.apache.commons.lang3.SystemUtils;
 import org.awaitility.Awaitility;
 import org.awaitility.core.ConditionTimeoutException;
-import org.jetbrains.annotations.NotNull;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -214,7 +213,7 @@ private void waitForReady() {
     }
   }
 
-  @NotNull
+  // @NotNull
   private ArrayList<String> createCommand(int port, List<AbstractAddon> addons) {
     ArrayList<String> command = new ArrayList<String>() {{
       add(getMitmproxyBinaryPath());
diff --git a/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/management/AddonsManagerClient.java b/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/management/AddonsManagerClient.java
index 8439a04e..6b7951ad 100644
--- a/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/management/AddonsManagerClient.java
+++ b/browserup-proxy-core/src/main/java/com/browserup/bup/mitmproxy/management/AddonsManagerClient.java
@@ -49,8 +49,7 @@ public <T> T requestToAddonsManager(String addOnPath,
                                         String contentType,
                                         Class<T> responseClass) {
         HttpRequest.Builder requestBuilder = HttpRequest.newBuilder()
-                .uri(buildRequestUrl(addOnPath, operation, queryParams))
-                .method(method, requestBody);
+                .uri(buildRequestUrl(addOnPath, operation, queryParams));
 
         if (requestBody != null) {
             requestBuilder.method(method, requestBody).header("Content-Type", contentType);