Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(suggestion) non-square pixel flag #108

Open
nlolnlolnlolnlo opened this issue May 25, 2024 · 2 comments
Open

(suggestion) non-square pixel flag #108

nlolnlolnlolnlo opened this issue May 25, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@nlolnlolnlolnlo
Copy link

it'd be nice to have an option alongside the "interlaced output" flag to automatically set the pixel aspect ratio of the output to be non-square. most ntsc video in the digital space is 720x480 displayed at a 4:3 aspect ratio, and as it stands it's a little bit annoying having to set that manually every time i render. could an option be added to flag the pixel aspect ratio on export?

@valadaptive valadaptive added the enhancement New feature or request label May 26, 2024
@valadaptive
Copy link
Owner

I'm testing this out now, and it seems like the DAR is properly passed through to the output video, although it doesn't show up in the preview. For instance, both of these videos have a SAR of 4:3 and a DAR of 2:1:

https://github.com/user-attachments/assets/b6e59d9e-4638-45df-8877-05745ed7e78d
https://github.com/user-attachments/assets/e9fd6bc5-804b-45f7-96a4-07cfecf7dc2a

Are there videos for which this doesn't work?

@valadaptive valadaptive added this to the 0.9.0 milestone Sep 18, 2024
@valadaptive
Copy link
Owner

valadaptive commented Oct 21, 2024

@nlolnlolnlolnlo Can you reproduce this in v0.8.1? Aspect ratios seem to be properly passed through when rendering even in older versions, and should display correctly in the preview in v0.8.1.

EDIT: Ah, is this a request to be able to add the aspect ratio flag to a video which doesn't have it already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants