Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plain length parameter #22

Open
ErikBoesen opened this issue May 13, 2019 · 3 comments
Open

Support plain length parameter #22

ErikBoesen opened this issue May 13, 2019 · 3 comments

Comments

@ErikBoesen
Copy link

Is your feature request related to a problem? Please describe.
My project calls for generating words of length n, rather than a range. It feels a little clunky to have to say minLength=n, maxLength=n.

Describe the solution you'd like
Implementation of a length parameter to get a word of length n.

Describe alternatives you've considered
N/A

Additional context
With your permission, I will implement this myself.

@vaibhavsingh97 vaibhavsingh97 added enhancement New feature or request New Feature labels Jun 15, 2019
@vaibhavsingh97
Copy link
Owner

Hi @ErikBoesen
Thanks for raising the issue, and I am happy to review your PR ❤️

@vaibhavsingh97
Copy link
Owner

Sorry, I think you missed this in the documentation, but minLength and maxLength already exist, you have to just pass as a parameter in the function, it's an optional parameter. please check: https://github.com/vaibhavsingh97/random-word#advance-usage

@vaibhavsingh97 vaibhavsingh97 removed New Feature enhancement New feature or request labels Jun 15, 2019
@ErikBoesen
Copy link
Author

I did read that in the documentation. What I'm suggesting is that it be possible to have one number specified for length. Right now if I want, say, a five-letter word, I have to specify maxLength=5, minLength=5, which makes the call unnecessarily verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants