Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mix camelCase and underscore_case #21

Open
ErikBoesen opened this issue May 13, 2019 · 2 comments
Open

Don't mix camelCase and underscore_case #21

ErikBoesen opened this issue May 13, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ErikBoesen
Copy link

Is your feature request related to a problem? Please describe.
I love this project, but don't like how it mixes camel case (i.e. for parameter names) with underscore (i.e. function names).

Describe the solution you'd like
Choosing one and sticking with it; preferably underscore_case as that's Python standard.

Describe alternatives you've considered
N/A

Additional context
I am happy to implement this myself if you say I can.

@ErikBoesen ErikBoesen changed the title Don't mix camelCae and underscore_case Don't mix camelCase and underscore_case May 13, 2019
@ErikBoesen
Copy link
Author

I know this would kind of screw up backward compatibility. For a time it might be appropriate to simply support both, then phase out the old style eventually, and people who want to keep using the old version can simply limit their version.

@vaibhavsingh97
Copy link
Owner

vaibhavsingh97 commented Jun 15, 2019

Hi @ErikBoesen 👋
Thanks for the love for this project, I am very glad you liked the project ❤.

don't like how it mixes camel case (i.e. for parameter names) with an underscore

I tried to follow PEP 008, please let me know, where I violated and would welcome a PR to fix the issue. Thanks for helping me out 🙌

@vaibhavsingh97 vaibhavsingh97 added the enhancement New feature or request label Feb 7, 2021
@vaibhavsingh97 vaibhavsingh97 self-assigned this Feb 7, 2021
@vaibhavsingh97 vaibhavsingh97 added the good first issue Good for newcomers label Mar 10, 2021
@vaibhavsingh97 vaibhavsingh97 removed their assignment Mar 10, 2021
@vaibhavsingh97 vaibhavsingh97 added the help wanted Extra attention is needed label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants