Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions #28

Open
lekoaf opened this issue Oct 1, 2020 · 0 comments
Open

Suggestions #28

lekoaf opened this issue Oct 1, 2020 · 0 comments

Comments

@lekoaf
Copy link

lekoaf commented Oct 1, 2020 •
edited
Loading

While working on the PR to convert this repo to typescript, I found a few things that perhaps could be improved.

For instance:

  • Add lib to .gitignore
  • Give the user the ability to specify their own globalBaseURL and globalCollectURL
  • Give the user the ability to send in options to electron-fetch (useful for proxy stuff etc)
  • globalBatchURL is unused. Should it be used or removed?
  • A lot of the parameter names are needlessly abbreviated. It just makes it harder for the user to use them.
  • This lib would be easier to use if you could send in all parameters as objects. It would also give nicer type interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lekoaf