Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code coverage workflow is failing #1199

Open
diegomrsantos opened this issue Sep 24, 2024 · 3 comments
Open

code coverage workflow is failing #1199

diegomrsantos opened this issue Sep 24, 2024 · 3 comments

Comments

@diegomrsantos
Copy link
Contributor

diegomrsantos commented Sep 24, 2024

We don't see coverage info on PRs anymore

It's possible to see the failure here https://github.com/vacp2p/nim-libp2p/actions/runs/10958882042/job/30430060780?pr=1183

@AlejandroCabeza
Copy link
Collaborator

The reason why coverage is failing is because we've reached the rate limit.
I recall adding a prevention measure during the CI refactor but it was disregarded. That being said, I think we would've reached the limit anyway.

The solution would be to go for a paid solution so we have a broader rate limit. Although maybe we won't hit the limit next month.

@diegomrsantos
Copy link
Contributor Author

diegomrsantos commented Sep 25, 2024

Which plan is best for me?
Developer - this plan is best for open-source projects and offers unlimited uploads or for single-user teams with small private repos and up to 250 coverage uploads per month.

@AlejandroCabeza
Copy link
Collaborator

Which plan is best for me? Developer - this plan is best for open-source projects and offers unlimited uploads or for single-user teams with small private repos and up to 250 coverage uploads per month.

I don't think I follow your point. If you're trying to suggest 250 should be enough, that's exactly what I implied with my "maybe we won't hit the limit next month".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: new
Development

No branches or pull requests

2 participants