Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using looks-same instead of pixelmatch for visual tests #243

Closed
web-padawan opened this issue Apr 21, 2021 · 1 comment
Closed
Labels

Comments

@web-padawan
Copy link
Member

It appears that pixelmatch does not fully handle anti-aliasing, see mapbox/pixelmatch#74

We could consider using looks-same to compare screenshots (we used it through gemini before).
This would require the following steps:

  1. write a custom diff function instead of pixelMatchDiff which comes out of the box
  2. pass this custom function to @web/test-runner-visual-regression via getImageDiff config option.

If this would requires some refactoring to the plugin, we can submit an issue to Modern Web project.

@sissbruecker
Copy link
Contributor

We closed this, as there are newer / more general tickets for fixing the visual tests. I tried the suggestion here, but it did not make a difference. After investigating it turns out both libraries use the same algorithm for anti-aliasing detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants