Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to enable native view transitions using the new View Transitions API #842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add option to enable native view transitions using the new View Transitions API #842

wants to merge 1 commit into from
+40 −18

Conversation

claytongulick
Copy link

@claytongulick claytongulick commented Mar 29, 2023 •
edited by jouni
Loading

Description

This is a simple addition to optionally enable the new View Transition API

Fixes #841

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lozandier
Copy link

@claytongulick Have the historical reviewers of this repo such as @platosha and @jouni ever contacted you to review this CL to merge this in?

If not, it may make sense for a friendly ping to @vursen and other contributors to vaadin's Web component repository that had commits as recent as last week

@jouni
Copy link
Member

jouni commented Jul 2, 2024

Looks nice in general (didn't read the code in detail) 👍 Shame on us for not handling this PR in a timely manner.

Note, though, that Vaadin has recently moved over to using React Router (in Vaadin 24.4), so this enhancement/feature won't have an impact on new Vaadin apps. React Router has preliminary support for native view transitions: https://reactrouter.com/en/main/hooks/use-view-transition-state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable native View Transition API
4 participants
@claytongulick @CLAassistant @lozandier @jouni