Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export a TypeScript type for 'vaadin-router-location-changed' event #681

Open
Haprog opened this issue Sep 28, 2021 · 0 comments
Open

Export a TypeScript type for 'vaadin-router-location-changed' event #681

Haprog opened this issue Sep 28, 2021 · 0 comments
Labels
DX enhancement New feature or request

Comments

@Haprog
Copy link
Contributor

Haprog commented Sep 28, 2021

Currently there is no TS type for the event vaadin-router-location-changed.

Router package should export a type like:

type RouterLocationChangedEvent = CustomEvent<{
  router: Router;
  location: RouterLocation;
}>;

so that it's easy to use the event in TS without having to cast the detail object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Haprog