Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make createMenuItems be based on a signal #2753

Merged
merged 3 commits into from
Sep 24, 2024
Merged

refactor: Make createMenuItems be based on a signal #2753

merged 3 commits into from
Sep 24, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Sep 21, 2024

Fixes #2752

@Artur- Artur- marked this pull request as ready for review September 23, 2024 07:49
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (c62bf0d) to head (a83528c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ages/ts/file-router/src/runtime/createMenuItems.ts 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2753   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          81       81           
  Lines        2648     2648           
  Branches      666      666           
=======================================
  Hits         2502     2502           
  Misses        142      142           
  Partials        4        4
Flag Coverage Δ
unittests 94.48% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi requested a review from Lodin September 23, 2024 11:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@platosha platosha merged commit 2386cfc into main Sep 24, 2024
14 of 15 checks passed
@platosha platosha deleted the menuitems-signal branch September 24, 2024 07:08
cromoteca pushed a commit that referenced this pull request Sep 27, 2024
@Artur- @cromoteca
refactor: Make createMenuItems be based on a signal (#2753)
e694ab8 
Fixes #2752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platosha platosha platosha approved these changes

@Lodin Lodin Awaiting requested review from Lodin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createMenuItems() is not reactive
2 participants
@Artur- @platosha