-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createMenuItems() is not reactive #2752
Comments
Artur-
added a commit
that referenced
this issue
Sep 21, 2024
Artur-
added a commit
that referenced
this issue
Sep 23, 2024
Artur-
added a commit
that referenced
this issue
Sep 23, 2024
Artur-
added a commit
that referenced
this issue
Sep 23, 2024
Artur-
added a commit
that referenced
this issue
Sep 23, 2024
Artur-
added a commit
that referenced
this issue
Sep 24, 2024
cromoteca
pushed a commit
that referenced
this issue
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
createMenuItems() uses data from
window.Vaadin.views
to render the menu but there is no mechanism that would update the menu hwenwindow.Vaadin.views
changes.Expected-behavior
Like everything else in React, the menu items should be reactive
Reproduction
The item appears in the menu on the next re-render, e.g. when navigating. It should appear immediately
System Info
Hilla: 24.5.0.beta1
Flow: 24.5.0.beta1
Vaadin: 24.5.0.beta1
Copilot: 24.5.0.beta1
Frontend Hotswap: Enabled, using Vite
OS: aarch64 Mac OS X 15.0
Java: JetBrains s.r.o. 21.0.3
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36
The text was updated successfully, but these errors were encountered: