Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source Flow apps don't check Control Center's feature flag #20013

Closed
2 tasks
mshabarov opened this issue Sep 20, 2024 · 1 comment · Fixed by #20024
Closed
2 tasks

Open source Flow apps don't check Control Center's feature flag #20013

mshabarov opened this issue Sep 20, 2024 · 1 comment · Fixed by #20024

Comments

@mshabarov
Copy link
Contributor

Description of the bug

Vaadin Flow does license checking for product vaadin-commercial-cc-client only when it spots any commercial component in the project, which is wrong, as a project can fairly be an open source project that is deployed with Control Center.

Instead, Flow should:

  • check this product for the apps that have no commercial products
  • check this product only when com.vaadin:control-center-starter dependency is present in the classpath, e.g. by checking Class::forName for some Java class in this artifact.

This would make a call to server when it's really needed.

Expected behavior

Flow should check this product for open source apps.

Minimal reproducible example

  1. Add
<dependency>
  <groupId>com.vaadin</groupId>
  <artifactId>control-center-starter</artifactId>
  <version>1.0-SNAPSHOT</version>
</dependency>

to a spring skeleton starter
2. Build open source Vaadin app for production and see that Flow doesn't make this call.

Versions

  • Vaadin / Flow version: 24.5.0.beta1
@tltv tltv self-assigned this Sep 23, 2024
tltv added a commit that referenced this issue Sep 23, 2024
Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013
vaadin-bot pushed a commit that referenced this issue Sep 23, 2024
* fix: Validate Control Center feature when used

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013

* chore: formatting
vaadin-bot added a commit that referenced this issue Sep 23, 2024
* fix: Validate Control Center feature when used

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013

* chore: formatting

Co-authored-by: Tomi Virtanen <[email protected]>
Artur- pushed a commit that referenced this issue Sep 24, 2024
* fix: Validate Control Center feature when used

Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.

Fixes: #20013

* chore: formatting
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment