You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Vaadin Flow does license checking for product vaadin-commercial-cc-client only when it spots any commercial component in the project, which is wrong, as a project can fairly be an open source project that is deployed with Control Center.
Instead, Flow should:
check this product for the apps that have no commercial products
check this product only when com.vaadin:control-center-starter dependency is present in the classpath, e.g. by checking Class::forName for some Java class in this artifact.
This would make a call to server when it's really needed.
Expected behavior
Flow should check this product for open source apps.
Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.
Fixes: #20013
* fix: Validate Control Center feature when used
Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.
Fixes: #20013
* chore: formatting
* fix: Validate Control Center feature when used
Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.
Fixes: #20013
* chore: formatting
Co-authored-by: Tomi Virtanen <[email protected]>
* fix: Validate Control Center feature when used
Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency.
Fixes: #20013
* chore: formatting
Description of the bug
Vaadin Flow does license checking for product
vaadin-commercial-cc-client
only when it spots any commercial component in the project, which is wrong, as a project can fairly be an open source project that is deployed with Control Center.Instead, Flow should:
com.vaadin:control-center-starter
dependency is present in the classpath, e.g. by checkingClass::forName
for some Java class in this artifact.This would make a call to server when it's really needed.
Expected behavior
Flow should check this product for open source apps.
Minimal reproducible example
to a spring skeleton starter
2. Build open source Vaadin app for production and see that Flow doesn't make this call.
Versions
The text was updated successfully, but these errors were encountered: