Skip to content

Commit

Permalink
Fix make vineyard_client_python on macos. (#1989)
Browse files Browse the repository at this point in the history
When running `make vineyard_client_python` on macos, get the following error:

```
ld: unknown option: --version-script=
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

Signed-off-by: Ye Cao <[email protected]>
  • Loading branch information
dashanji authored Aug 21, 2024
1 parent cffa4d2 commit ee11896
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,9 @@ if(BUILD_VINEYARD_PYTHON_BINDINGS)
DEPENDS _C vineyard_internal_registry
COMMENT "Copying python extensions."
VERBATIM)
set_target_properties(_C PROPERTIES LINK_FLAGS "-Wl,--version-script=${LIBFABRIC_VERSION_SCRIPT}")
if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
set_target_properties(_C PROPERTIES LINK_FLAGS "-Wl,--version-script=${LIBFABRIC_VERSION_SCRIPT}")
endif()
endif()

if(BUILD_VINEYARD_PYTHON_BINDINGS AND BUILD_VINEYARD_LLM_CACHE)
Expand All @@ -1027,7 +1029,9 @@ if(BUILD_VINEYARD_PYTHON_BINDINGS AND BUILD_VINEYARD_LLM_CACHE)
DEPENDS _llm_C
COMMENT "Copying llm kv cache python extensions."
VERBATIM)
set_target_properties(_llm_C PROPERTIES LINK_FLAGS "-Wl,--version-script=${LIBFABRIC_VERSION_SCRIPT}")
if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
set_target_properties(_llm_C PROPERTIES LINK_FLAGS "-Wl,--version-script=${LIBFABRIC_VERSION_SCRIPT}")
endif()
add_dependencies(vineyard_llm_python vineyard_client_python)
endif()

Expand Down

0 comments on commit ee11896

Please sign in to comment.