Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking Issue] Redesign the internal storage of sparse buffers. #65

Open
3 tasks
yzh119 opened this issue Nov 14, 2022 · 0 comments
Open
3 tasks

[Tracking Issue] Redesign the internal storage of sparse buffers. #65

yzh119 opened this issue Nov 14, 2022 · 0 comments

Comments

@yzh119
Copy link
Member

yzh119 commented Nov 14, 2022

Pitch

In the current design of SparseTIR, the internal storage of the value field of sparse buffers is 1D and the sparse buffer lowering pass would flatten every sparse buffer to 1-dimensional.

However, such a design is not necessary because we only want to flatten variable axes, while keeping the dimensions of fixed axes. More specifically:

# before flattening
I = T.dense_fixed(m, "int32")
J = T.dense_fixed(I, (n, nnz), (indptr, indices), "int32")
K = T.dense_fixed(k, "int32")
A = T.match_sparse_buffer(a, (I, J, K), "float32")

# after flattening (previous behavior)
A = T.match_buffer(a, (nnz * k,), "float32")

# after flattening (new behavior)
A = T.match_buffer(a, (nnz, k), "float32")

we should only flatten a "variable" axes chain and leave other axes in their original form, such design can help us reuse the schedules for "dense" parts of the tensor program when integrated with relax, the graph-level IR in TVM stack.

More specifically, sparse_fixed axes do not need to be flattened because they are fixed, the following is a case of a 8x4 sparse matrix with 2:4 sparsity:

I = T.dense_fixed(8, "int32")
J = T.sparse_fixed(I, (4, 2), indices, "int32")
A = T.match_sparse_buffer(a, (I, J), "float32")

# after flattening
A = T.match_sparse_buffer(a, (8, 2), "float32")

after flattening, it becomes a 8x2 compact dense matrix with shape 8x2.

The new design also enables us to move some of the schedules (e.g. 2:4 sparse tensor core tensorization) to stage III IR.

Checklist

  • Refactor the data structure.
  • Refactor LowerSparseBuffer pass.
  • Fix all examples.
@yzh119 yzh119 moved this to TODO in SparseTIR Nov 15, 2022
@yzh119 yzh119 added this to SparseTIR Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TODO
Development

No branches or pull requests

1 participant