-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate correction for 2D WE #7
Comments
@ShaunHadden I just added this issue to track the need for handling 2D vs. 3D Green's functions. This is one of the topics that came up in the meeting with Gerhard this morning. It should be semi-general for all of the methods, so we should either implement it in |
ok! This says self-assigned to you, so I am assuming no action is required from me, which makes sense since you said these were just FYI |
Yes, exactly :) |
I''ve made the change to the 'Dz' calculation that was wrong on the timedomain branch for eurus.py. This still needs more work so perhaps we should wait to merge it into master? |
Thanks for letting me know, but we should use these issues to discuss specific topics, and not mix in other issues. I have created a new spot to discuss the Eurus discretization: #8 |
Need to include a wrapper for the 2D wave equation examples that automatically corrects for the 2D vs. 3D Green's function (i.e., half differentiation, half integration).
The text was updated successfully, but these errors were encountered: