From 46c28776c8daf1c8a3ba10fba312c749d7d66cb5 Mon Sep 17 00:00:00 2001 From: mike seibel Date: Tue, 13 Feb 2024 17:07:23 -0800 Subject: [PATCH 1/3] add departmental support shared to office 356 student service --- endorsement/services/office365student.py | 1 + 1 file changed, 1 insertion(+) diff --git a/endorsement/services/office365student.py b/endorsement/services/office365student.py index d72d407b..77d1e625 100644 --- a/endorsement/services/office365student.py +++ b/endorsement/services/office365student.py @@ -44,6 +44,7 @@ def shared_params(self): """ return { 'roles': ['owner', 'owner-admin'], + 'types': ['shared', 'support'], 'types': ['shared'], 'excluded_categories': [ Category.ALTID_SHARED_CLINICAL_1] From 1aef55e1e71583ffd3e6437d007d4a3b4c63365b Mon Sep 17 00:00:00 2001 From: mike seibel Date: Thu, 15 Feb 2024 13:27:43 -0800 Subject: [PATCH 2/3] proper dict --- endorsement/services/office365student.py | 1 - 1 file changed, 1 deletion(-) diff --git a/endorsement/services/office365student.py b/endorsement/services/office365student.py index 77d1e625..1f9ca3e0 100644 --- a/endorsement/services/office365student.py +++ b/endorsement/services/office365student.py @@ -45,7 +45,6 @@ def shared_params(self): return { 'roles': ['owner', 'owner-admin'], 'types': ['shared', 'support'], - 'types': ['shared'], 'excluded_categories': [ Category.ALTID_SHARED_CLINICAL_1] } From 8b06047e991e793de61e2c7061b550c83314744c Mon Sep 17 00:00:00 2001 From: mike seibel Date: Thu, 15 Feb 2024 13:37:15 -0800 Subject: [PATCH 3/3] add test for support shared type --- endorsement/test/services/test_office365student.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/endorsement/test/services/test_office365student.py b/endorsement/test/services/test_office365student.py index 4c16f518..00923fc6 100644 --- a/endorsement/test/services/test_office365student.py +++ b/endorsement/test/services/test_office365student.py @@ -65,7 +65,7 @@ def test_shared(self): self.assertTrue(data['endorser']['netid'] == 'jstaff') endorsible, endorsed = self.get_shared(data) - self.assertEquals(len(endorsible), 7) + self.assertEquals(len(endorsible), 10) self.assertEquals(len(endorsed), 1) self.assertTrue('cpnebeng' in endorsible) self.assertTrue('phil123' in endorsible)