Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Graceful node draining before termination #5

Open
JoelSpeed opened this issue Sep 21, 2018 · 2 comments
Open

Feature Request: Graceful node draining before termination #5

JoelSpeed opened this issue Sep 21, 2018 · 2 comments

Comments

@JoelSpeed
Copy link

It doesn't look to me as if the code uses any graceful draining of the Kubernetes nodes at present?

It would be good to add this into the node termination procedure so that pods are moved off of the instance before termination on AWS.

I'm thinking about cases when terminating a node would disrupt a PDB, if there's no budget then ideally you wouldn't terminate the node until there is budget

@Joseph-Irving
Copy link
Contributor

We could add this as a flag --drain-nodes or something. You could get into a weird state where it's draining the node it's on so you would have to work around that.

It was intentional to have it aggressively terminate nodes as it will expose single points of failure and kind of simulate a node breaking.

@Joseph-Irving
Copy link
Contributor

So we could get around the draining problem by just filtering out the surtr pod by label when draining the node so that should work actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants