From d4eb1afe036c0a30a163ac7f40820f8b56ededea Mon Sep 17 00:00:00 2001 From: wonseok2877 Date: Tue, 13 Feb 2024 17:07:56 +0900 Subject: [PATCH] =?UTF-8?q?comment:=20TODO=20=EC=A0=9C=EA=B1=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../usw/suwiki/domain/evaluatepost/domain/EvaluatePost.java | 1 - src/main/java/usw/suwiki/domain/lecture/domain/Lecture.java | 1 - .../usw/suwiki/global/util/emailBuild/BuildEmailAuthForm.java | 2 -- .../java/usw/suwiki/global/util/loadjson/USWTermResolver.java | 4 +--- 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/main/java/usw/suwiki/domain/evaluatepost/domain/EvaluatePost.java b/src/main/java/usw/suwiki/domain/evaluatepost/domain/EvaluatePost.java index ee7c16b2..55fa3b38 100644 --- a/src/main/java/usw/suwiki/domain/evaluatepost/domain/EvaluatePost.java +++ b/src/main/java/usw/suwiki/domain/evaluatepost/domain/EvaluatePost.java @@ -52,7 +52,6 @@ public class EvaluatePost extends BaseTimeEntity { @Column(columnDefinition = "TEXT", nullable = false) private String content; //주관적인 강의평가 입력내용 - // TODO: 연관관계 편의 메서드로 대체 public void setLecture(Lecture lecture) { this.lecture = lecture; } diff --git a/src/main/java/usw/suwiki/domain/lecture/domain/Lecture.java b/src/main/java/usw/suwiki/domain/lecture/domain/Lecture.java index 0d68858f..6ee4fe0d 100644 --- a/src/main/java/usw/suwiki/domain/lecture/domain/Lecture.java +++ b/src/main/java/usw/suwiki/domain/lecture/domain/Lecture.java @@ -27,7 +27,6 @@ public class Lecture extends BaseTimeEntity { @GeneratedValue(strategy = GenerationType.IDENTITY) private Long id; - // TODO refactor: Embeddable 객체로 분리 @Column(name = "semester_list") private String semester; diff --git a/src/main/java/usw/suwiki/global/util/emailBuild/BuildEmailAuthForm.java b/src/main/java/usw/suwiki/global/util/emailBuild/BuildEmailAuthForm.java index 6ab3f453..c4ac1100 100644 --- a/src/main/java/usw/suwiki/global/util/emailBuild/BuildEmailAuthForm.java +++ b/src/main/java/usw/suwiki/global/util/emailBuild/BuildEmailAuthForm.java @@ -11,11 +11,9 @@ public class BuildEmailAuthForm { private static final String CONFIRMATION_TOKEN_URL = "/v2/confirmation-token/verify/?token="; private final ServerProperties serverProperties; - // TODO: refactor static 메서드 고민. serverProperties를 외부에서 주입받아야 함 public String buildEmail(ConfirmationToken confirmationToken) { String redirectUrl = buildRedirectUrl(confirmationToken); - // TODO refactor: 반복성 제거. 템플릿 메서드 패턴 혹은 타임 리프 고민 return "
\n" + "\t" + diff --git a/src/main/java/usw/suwiki/global/util/loadjson/USWTermResolver.java b/src/main/java/usw/suwiki/global/util/loadjson/USWTermResolver.java index c7a2efa8..6496afee 100644 --- a/src/main/java/usw/suwiki/global/util/loadjson/USWTermResolver.java +++ b/src/main/java/usw/suwiki/global/util/loadjson/USWTermResolver.java @@ -5,14 +5,12 @@ public final class USWTermResolver { private static final String[] KEYWORDS_TO_REMOVE = {"재수강", "비대면수업", "대면수업", "혼합수업"}; - // TODO refactor: REGEX 검사 // 변환에 필요한 최소한의 스트링 형식입니다. // 해당 형식에 맞지 않는다면 수원대측에서 형식을 바꾼 것이므로 더 이상 호환되지 않기 때문에 예외를 발생시키고 적재를 중단해야 합니다. - // https://regexr.com/7rq1g + // https://regexr.com/7rq1g "^([\\s가-힣A-Za-z\\d-]+\\([월화수목금토일]\\d+(?:,\\d+)*.*?\\))+$" // pass : "강의실107-1(수6,7,8)" "강의실 B215(화5,6,7 수5,6,7)" // pass : "(월1,2)" -> "미정(월1,2)" // fail : "강의실(1,2)" "강의실 월1,2" "강의실107(요일아님6,7,8)" "요일없음(1,2)" "강의실103(화5,6),강의실103" -// private static final String PLACE_SCHEDULE_REGEX = "^([\\s가-힣A-Za-z\\d-]+\\([월화수목금토일]\\d+(?:,\\d+)*.*?\\))+$"; private static final String ESTABLISHED_YEAR = "subjtEstbYear"; private static final String ESTABLISHED_SEMESTER = "subjtEstbSmrCd";