Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-borg step #14

Open
guyer opened this issue Sep 28, 2023 · 3 comments
Open

Add pre-borg step #14

guyer opened this issue Sep 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@guyer
Copy link
Member

guyer commented Sep 28, 2023

As noted by @ianhbell via email: "It would be nice to have the chance to do some things pre-borging, for instance running doxygen and executing notebooks after borging is much more complicated with the fact that the doc folder has moved during borging and the hard-coded paths all need to be fixed up throughout my scripts and config files. It would be nice if this could run after the conda environment is loaded."

@guyer guyer added the enhancement New feature or request label Sep 28, 2023
@ianhbell
Copy link

I added that in my fork, but I don't see a good way to do a PR with cherry picking into a feature branch because you need to test in main (or am I mistaken?)

@guyer
Copy link
Member Author

guyer commented Sep 29, 2023

In .github/workflows/NISTtheDocs2Death.yml, you can change usnistgov/NISTtheDocs2Death@main to my-fork/NISTtheDocs2Death@my-feature-branch. This won't be able to test the push to pages.nist.gov, but it should do the rest. For PRs on the usnistgov repo, usnistgov/NISTtheDocs2Death@my-feature-branch will exercise the full workflow.

@ianhbell
Copy link

Good I thought that might be the case but didn't get a chance to test yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants