Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashCodes of ISourceLocation implementations not uniform? #72

Open
jurgenvinju opened this issue Mar 27, 2020 · 2 comments
Open

hashCodes of ISourceLocation implementations not uniform? #72

jurgenvinju opened this issue Mar 27, 2020 · 2 comments

Comments

@jurgenvinju
Copy link
Member

The (many different) hashCode implementations of ISourceLocation simply add the hashcodes of their constituent strings.

  • find out how bad this distribution gets, and if its worth coming up with a better but more expensive computation
  • improve the computation if needed.
@DavyLandman
Copy link
Member

Maybe we should all change them to invocations of Objects.hashCode() ? or inline that logic?

@jurgenvinju
Copy link
Member Author

jurgenvinju commented Jun 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants