Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code is interpretting location in debugger view incorrectly. #372

Open
koenvanwijk opened this issue May 1, 2024 · 4 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@koenvanwijk
Copy link

Describe the bug

The location links in the debugger variable window fail to load the correct file.

To Reproduce
image

Steps to reproduce the behavior:

  1. Start the debugger
  2. Ctrl-click any location link.

Expected behavior
I expect the file to open and highlight the correct location.

Screenshots

Stack traces

Literally copy stacktraces from the console, or from the Eclipse Error log here.

Desktop (please complete the following information):

  • Context: VS Code extension
  • Rascal Version (e.g. rascal 0.34.1 in rascal-vscode 0.10.2)?

Additional context
Add any other context about the problem here.

@koenvanwijk koenvanwijk added the bug Something isn't working label May 1, 2024
@DavyLandman
Copy link
Member

True this is an open issue, it's a variant of this generic #293.

When writing the debugger last year, it was not possible to provide custom actions for debug values, but there is a new API announced that we should take a look at, that would allow us to provide custom debug value viewers etc.

@koenvanwijk
Copy link
Author

Who is stripping the begin and end character?

@DavyLandman
Copy link
Member

VS Code is automatically detecting a 'bare' URI inside of the rascal location. And in other places (like the terminal) VS code has an extension point for us to explain: no actually, that's a location and this is where it points to in the file etc. they've recently added this click feature to debugger values, so we should figure out if we can teach vs code about source locations.

(I'm allocating some time in the near future to figure out what's possible)

@DavyLandman
Copy link
Member

Ok, it's a proposed API (so not available yet for general extensions, but tends to be used internally).

Looks like once it's finished, we'll be able to add visualizers for ParseTrees and locations and the rest of the values.

@DavyLandman DavyLandman added the enhancement New feature or request label May 3, 2024
@DavyLandman DavyLandman changed the title location links in debugger variable fail VS Code is interpretting location links in debugger view incorrectly. May 3, 2024
@DavyLandman DavyLandman changed the title VS Code is interpretting location links in debugger view incorrectly. VS Code is interpretting location in debugger view incorrectly. May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants