Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce checks which verify that Dockerfile doesn't contain labels which OSBS sets #137

Open
3 tasks
TomasTomecek opened this issue May 25, 2018 · 2 comments
Labels
feature New feature or a request for enhancement.

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented May 25, 2018

This is a low-prio RFE, mainly added here just to track the problem.

@TomasTomecek TomasTomecek added the feature New feature or a request for enhancement. label May 25, 2018
@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented May 25, 2018

new class to check that a label is NOT present

This is already done -- you should only set required = False.

It should be something like this:

      "names": [
        "one",
        "two"
      ],
      "required": false,
      "message": "This label is automatically set by OSBS, do not set them in the Dockerfile.",
      "additional_tags": [
        "required",
         "osbs"
      ],
      "usable_targets": [
        "dockerfile"
      ]

@TomasTomecek
Copy link
Member Author

But still, we would have to create a new check (just tried this out).

Actually required confuses me a bit; probably should_be_present would make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or a request for enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants