Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure check for presence of maintainer check works #130

Open
TomasTomecek opened this issue May 21, 2018 · 4 comments
Open

Make sure check for presence of maintainer check works #130

TomasTomecek opened this issue May 21, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented May 21, 2018

We've got a report internally that $subject does not work. Please investigate and ideally create a test case for this.

I am pretty sure the "WARN:Label 'maintainer' has to be specified." is a
false warning, unless I am blind and can not see the typo in my Dockerfile.

CC @fkluknav

Edit: I think I get it know, the message is wrong. We check whether the content matches a certain regex.

@TomasTomecek TomasTomecek added the bug Something isn't working label May 21, 2018
@fkluknav
Copy link

LABEL maintainer="Red Hat, Inc."
causes
WARN:Label 'maintainer' has to be specified.

@TomasTomecek
Copy link
Member Author

Yeah, our regex is @redhat.com$. This is worth discussing internally.

@fkluknav
Copy link

What is the standard for 'maintainer' label in images from Red Hat? Is there any? A person? A group? A company?

@TomasTomecek
Copy link
Member Author

Exactly, probably there is none. Therefore this should be brought up internally so we all agree on one standard.

@fkluknav Would you like to bring it up or should we take care of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants